Replace e2e-vsphere-capi-techpreview with customnoupgrade-migration for cluster-capi-operator - #84593
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe vSphere CAPI migration test was renamed, switched from ChangesvSphere CAPI migration test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the vSphere CAPI migration presubmit configuration to use CustomNoUpgrade with targeted migration feature gates. No unresolved merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-vsphere-capi-devpreview |
|
@AnnaZivkovic: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2c82e9f to
546a2f2
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-vsphere-capi-customnoupgrade-migration |
|
@AnnaZivkovic: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@AnnaZivkovic: job(s): pull-ci-openshift-cluster-api-actuator-pkg-master-e2e-vsphere-capi-customnoupgrade-migration either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-vsphere-capi-customnoupgrade-migration |
|
@AnnaZivkovic: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
546a2f2 to
262efcf
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-vsphere-capi-customnoupgrade-migration |
|
@AnnaZivkovic: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@AnnaZivkovic: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse --pull=openshift/cluster-capi-operator#455 pull-ci-openshift-cluster-capi-operator-main-e2e-vsphere-capi-customnoupgrade-migration |
|
@AnnaZivkovic: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@AnnaZivkovic: job(s): --pull=openshift/cluster-capi-operator#455 either don't exist or were not found to be affected, and cannot be rehearsed |
|
/lgtm Note that this didn't actually run the target tests, yet because they're skipped on non-AWS. |
|
@AnnaZivkovic try rebasing this and re-running 'make jobs' to see if that config change goes away. If it does it won't require additional approval. |
262efcf to
8939f04
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse --pull=openshift/cluster-capi-operator#455 pull-ci-openshift-cluster-capi-operator-main-e2e-vsphere-capi-customnoupgrade-migration |
|
@AnnaZivkovic: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@AnnaZivkovic: job(s): --pull=openshift/cluster-capi-operator#455 either don't exist or were not found to be affected, and cannot be rehearsed |
AnnaZivkovic
changed the title
8939f04 to
d7ec031
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cluster-capi-operator-main-e2e-vsphere-capi-customnoupgrade-migration |
|
@AnnaZivkovic: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AnnaZivkovic, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@mdbooth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
2 participants
Summary
for openshift/cluster-capi-operator (main branch)
CAPI machine migration: MachineAPIMigration, MachineAPIMigrationVSphere, ClusterAPIMachineManagement,
ClusterAPIMachineManagementVSphere
Why
The vSphere CAPI migration tests (MachineSet migration, VAP tests) require specific feature gates
(MachineAPIMigrationVSphere, ClusterAPIMachineManagementVSphere) that are available under
CustomNoUpgrade. Using CustomNoUpgrade instead of DevPreview provides a more realistic test
environment that matches how customers will selectively enable these features.
Summary by CodeRabbit
Updates
openshift/cluster-capi-operatormain-branch CI to run vSphere CAPI migration tests withCustomNoUpgrade. The job enables the required Machine API and vSphere migration feature gates without enabling all TechPreview or DevPreview features.